[PATCH] D66882: [DAGCombiner] Match (add X, X) as (shl X, 1) when detecting rotate.
Amaury SECHET via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 30 10:13:49 PDT 2019
deadalnix marked 3 inline comments as done.
deadalnix added inline comments.
================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6120
// result matches up with the existing shift's LHS op.
if (IsMulOrDiv) {
// Op to extract from is a mul or udiv by a constant.
----------------
lebedev.ri wrote:
> Hm, this function already handles non-shifts.
> Can it simply be extended with a similar block?
The whole function is about reconstructing shifts from something else.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66882/new/
https://reviews.llvm.org/D66882
More information about the llvm-commits
mailing list