[PATCH] D63782: [FPEnv] Add fptosi and fptoui constrained intrinsics

[Craig Topper via Phabricator via llvm-commits]

craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:5378
+    if (Node->isStrictFPOpcode()) {
+      Result = DAG.getNode(ISD::STRICT_FP_TO_SINT, dl, { DstVT, MVT::Other }, 
+                           { Node->getOperand(0), Src }); 
----------------
kpn wrote:
> craig.topper wrote:
> > This isn't used below is it? The else block here returns true but this block continues. But the continuation code assigns Result without ever reading it.
> The else is a call to getNode() for regular ISD::FP_TO_SINT. Then both legs fall through to the return true.
Oops. I think the lack of curly braces on the else and the comments in this area made me miss the indentation change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63782/new/

https://reviews.llvm.org/D63782