[PATCH] D63782: [FPEnv] Add fptosi and fptoui constrained intrinsics

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 27 09:32:08 PDT 2019


kpn marked an inline comment as done.
kpn added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:5378
+    if (Node->isStrictFPOpcode()) {
+      Result = DAG.getNode(ISD::STRICT_FP_TO_SINT, dl, { DstVT, MVT::Other }, 
+                           { Node->getOperand(0), Src }); 
----------------
craig.topper wrote:
> This isn't used below is it? The else block here returns true but this block continues. But the continuation code assigns Result without ever reading it.
The else is a call to getNode() for regular ISD::FP_TO_SINT. Then both legs fall through to the return true.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63782/new/

https://reviews.llvm.org/D63782





More information about the llvm-commits mailing list