[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

Mirko Brkusanin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 27 03:42:18 PDT 2019


mbrkusanin added a comment.

- adjustPrefixes() is not called after every call of createMCAsmInfo(), only where MCTargetOptions is available since this is what tells us if ABI is given as argument.

- StringRef CPU could be removed from adjustPrefixes() since MipsABIInfo::computeTargetABI() does not use it in it's implementation and an empty string could be passed. We could remove Triple as well and use MCTargetOptions.ABIName only and read it manualy, but this way we would keep it consistent with other uses of MipsABIInfo.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66795/new/

https://reviews.llvm.org/D66795





More information about the llvm-commits mailing list