[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

[Mirko Brkusanin via Phabricator via llvm-commits]

mbrkusanin created this revision.
mbrkusanin added reviewers: atanasyan, petarj, mstojanovic, sdardis.
mbrkusanin added a project: LLVM.
Herald added subscribers: gbedwell, arichardson.
Herald added a reviewer: JDevlieghere.
Herald added a reviewer: andreadb.
mbrkusanin added a comment.

- adjustPrefixes() is not called after every call of createMCAsmInfo(), only where MCTargetOptions is available since this is what tells us if ABI is given as argument.

- StringRef CPU could be removed from adjustPrefixes() since MipsABIInfo::computeTargetABI() does not use it in it's implementation and an empty string could be passed. We could remove Triple as well and use MCTargetOptions.ABIName only and read it manualy, but this way we would keep it consistent with other uses of MipsABIInfo.


MipsMCAsmInfo was using '$' prefix for Mips32 and '.L' for Mips64 regardless of 
-target-abi option. By checking MCTargetOptions we can find out Mips ABI and
pick appropriate prefix.


https://reviews.llvm.org/D66795

Files:
  include/llvm/MC/MCAsmInfo.h
  lib/CodeGen/LLVMTargetMachine.cpp
  lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp
  lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.h
  test/CodeGen/Mips/compactbranches/no-beqzc-bnezc.ll
  test/MC/Mips/macro-li.d.s
  test/MC/Mips/macro-li.s.s
  test/MC/Mips/private-prefix.s
  tools/dsymutil/DwarfStreamer.cpp
  tools/llvm-dwp/llvm-dwp.cpp
  tools/llvm-mc-assemble-fuzzer/llvm-mc-assemble-fuzzer.cpp
  tools/llvm-mc/Disassembler.h
  tools/llvm-mc/llvm-mc.cpp
  tools/llvm-mca/llvm-mca.cpp
  unittests/DebugInfo/DWARF/DwarfGenerator.cpp
  unittests/ExecutionEngine/JITLink/JITLinkTestCommon.cpp
  unittests/ExecutionEngine/JITLink/JITLinkTestCommon.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66795.217350.patch
Type: text/x-patch
Size: 18041 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190827/0955eafb/attachment.bin>