[PATCH] D66749: [ELF][ARM] Allow PT_LOAD to have overlapping p_offset ranges on EM_ARM

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: ELF/Writer.cpp:2232
+                    config->emachine == EM_ARM || config->emachine == EM_PPC ||
+                    config->emachine == EM_PPC64;
 
----------------
ruiu wrote:
> grimar wrote:
> > This became large. I am not sure, but does it make sense to invert the condition?
> > 
> > I.e:
> > 
> > ```
> > bool disabled = ....;
> > ```
> I think this is fine -- this will go away soon once he migrated all the ports.
I plan to do this after RISC-V is fixed => then I think I'll do config->emachine != EM_MIPS && config->emachine != EM_X86_64.


================
Comment at: test/ELF/arm-fpic-got.s:63
 // CODE: $d.1:
-// 0x11004 + 0x0ff4 + 8 = 0x12000 = .got
-// CODE-NEXT:   11010:  f4 0f 00 00
+// 0x11124 + 0x1008 + 8 = 0x12134 = .got
+// CODE-NEXT:   11124:       08 10 00 00
----------------
grimar wrote:
> `0x12134` is not `.got` address, `.got` is at `0x12128`
Thanks!


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66749/new/

https://reviews.llvm.org/D66749