[PATCH] D66749: [ELF][ARM] Allow PT_LOAD to have overlapping p_offset ranges on EM_ARM
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 27 02:15:42 PDT 2019
ruiu added a comment.
I think this patch doesn't have to be split. As long as the modified tests test the same thing as before, I'm not worried too much, and splitting it into multiple pieces would probably bee too laborious.
================
Comment at: ELF/Writer.cpp:2232
+ config->emachine == EM_ARM || config->emachine == EM_PPC ||
+ config->emachine == EM_PPC64;
----------------
grimar wrote:
> This became large. I am not sure, but does it make sense to invert the condition?
>
> I.e:
>
> ```
> bool disabled = ....;
> ```
I think this is fine -- this will go away soon once he migrated all the ports.
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66749/new/
https://reviews.llvm.org/D66749
More information about the llvm-commits
mailing list