[PATCH] D66537: [DAGCombiner] Remove a bunch of redundant AddToWorklist calls.

Mon Aug 26 16:25:59 PDT 2019

Looks like we ended up with a shift with the amount as an i64 instead of
i8. The isel patterns only match i8 amounts.

~Craig

On Mon, Aug 26, 2019 at 4:16 PM Nathan Chancellor via Phabricator <
reviews at reviews.llvm.org> wrote:

> nathanchance added a comment.
>
> My instrumented stage 2 build fails after this commit with this script <
> https://github.com/ClangBuiltLinux/tc-build>.
>
>   > ./build-llvm.py --no-update --pgo --targets X86
>   ...
>   [2240/2679] Building CXX object
> tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ASTReader.cpp.o
>   FAILED:
> tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ASTReader.cpp.o
>   /home/nathan/cbl/git/tc-build/build/llvm/stage1/bin/clang++
> -DCLANG_VENDOR="\"ClangBuiltLinux \"" -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE
> -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
> -Itools/clang/lib/Serialization
> -I/home/nathan/cbl/git/tc-build/llvm-project/clang/lib/Serialization
> -I/home/nathan/cbl/git/tc-build/llvm-project/clang/include
> -Itools/clang/include -I/usr/include/libxml2 -Iinclude
> -I/home/nathan/cbl/git/tc-build/llvm-project/llvm/include -fPIC
> -fvisibility-inlines-hidden -Werror=date-time
> -Werror=unguarded-availability-new -std=c++14 -w -fdiagnostics-color
> -ffunction-sections -fdata-sections
> -fprofile-generate='/home/nathan/cbl/git/tc-build/build/llvm/stage2/profiles'
> -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG
> -fno-exceptions -fno-rtti -MD -MT
> tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ASTReader.cpp.o
> -MF
> tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ASTReader.cpp.o.d
> -o
> tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ASTReader.cpp.o
> -c
> /home/nathan/cbl/git/tc-build/llvm-project/clang/lib/Serialization/ASTReader.cpp
>   fatal error: error in backend: Cannot select: 0xfe3cc48: i64 = shl
> 0x117c5360, Constant:i64<32>
>     0x117c5360: i64,ch = load<(load 4 from %ir.255 + 12), zext from i32>
> 0x104ce840, 0x119702e0, undef:i64
>       0x119702e0: i64 = add nuw 0x1196e8d8, Constant:i64<4>
>         0x1196e8d8: i64 = add 0x117ced30, Constant:i64<16>
>           0x117ced30: i64,ch = load<(dereferenceable load 8 from %ir.32,
> !tbaa !9)> 0x104ce840, FrameIndex:i64<2>, undef:i64
>             0x119d4430: i64 = FrameIndex<2>
>             0x119d3a08: i64 = undef
>           0x119d4228: i64 = Constant<16>
>         0x10385118: i64 = Constant<4>
>       0x119d3a08: i64 = undef
>     0x11a762d0: i64 = Constant<32>
>   In function:
> _ZN5clang9ASTReader22ParseDiagnosticOptionsERKN4llvm11SmallVectorImLj64EEEbRNS_17ASTReaderListenerE
>   clang-10: error: clang frontend command failed with exit code 70 (use -v
> to see invocation)
>   ClangBuiltLinux clang version 10.0.0 (git://github.com/llvm/llvm-project
> b7075e40f3c2244073fed1bf64f922165987f68a) (based on LLVM 10.0.0svn)
>   Target: x86_64-unknown-linux-gnu
>   Thread model: posix
>   InstalledDir: /home/nathan/cbl/git/tc-build/build/llvm/stage1/bin
>   clang-10: note: diagnostic msg: PLEASE submit a bug report to
> https://bugs.llvm.org/ and include the crash backtrace, preprocessed
> source, and associated run script.
>   clang-10: note: diagnostic msg:
>   ********************
>
>   PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
>   Preprocessed source(s) and associated run script(s) are located at:
>   clang-10: note: diagnostic msg: /tmp/ASTReader-e6c71c.cpp
>   clang-10: note: diagnostic msg: /tmp/ASTReader-e6c71c.sh
>   clang-10: note: diagnostic msg:
>
>   ********************
>   ...
>   > git -C llvm-project bisect log
>   # bad: [8679ef4e46a4d7b46a521a905d60357854117d43] [driver] add a new
> option `-gen-cdb-fragment-path` to emit a fragment of a compilation
> database for each compilation
>   # good: [894b8d1d85a13fe106411c996e26e571c00dbb78] FileManager: Factor
> duplicated code in getBufferForFile, NFC
>   git bisect start 'origin/master' '894b8d1d85a'
>   # good: [f899bf135fc5b7bb030b90da686d9d89bb97d18f] Fix windows build
> after r369894
>   git bisect good f899bf135fc5b7bb030b90da686d9d89bb97d18f
>   # good: [442a5765ce0c1594874a44f7aa210dfd0e0c5c35] [PowerPC] add tests
> for fma with negated ops; NFC
>   git bisect good 442a5765ce0c1594874a44f7aa210dfd0e0c5c35
>   # bad: [7305397a142a60d104e02ef1046b4289f957da95] TestFunctionStarts.py:
> add synchronization
>   git bisect bad 7305397a142a60d104e02ef1046b4289f957da95
>   # good: [e30b71f9dc0fdf12c3ea2ce4541ca8ce4af2aa67] Fix -dA flag, it is
> not a preprocessor flag.
>   git bisect good e30b71f9dc0fdf12c3ea2ce4541ca8ce4af2aa67
>   # bad: [3ba0f3c9b7f1c0227ed7771168fa9362cfea213e] [NFC] Add comments to
> some bool arguments for better readability
>   git bisect bad 3ba0f3c9b7f1c0227ed7771168fa9362cfea213e
>   # bad: [b7075e40f3c2244073fed1bf64f922165987f68a] [DAGCombiner] Remove a
> bunch of redundant AddToWorklist calls.
>   git bisect bad b7075e40f3c2244073fed1bf64f922165987f68a
>   # first bad commit: [b7075e40f3c2244073fed1bf64f922165987f68a]
> [DAGCombiner] Remove a bunch of redundant AddToWorklist calls.
>
> F9862512: ASTReader-e6c71c.sh <https://reviews.llvm.org/F9862512>
>
> F9862507: ASTReader-e6c71c.cpp <https://reviews.llvm.org/F9862507>
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D66537/new/
>
> https://reviews.llvm.org/D66537
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190826/c4ad575d/attachment.html>