<div dir="ltr"><div>Looks like we ended up with a shift with the amount as an i64 instead of i8. The isel patterns only match i8 amounts.</div><div><br></div><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">~Craig</div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 26, 2019 at 4:16 PM Nathan Chancellor via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">nathanchance added a comment.<br>
<br>
My instrumented stage 2 build fails after this commit with this script <<a href="https://github.com/ClangBuiltLinux/tc-build" rel="noreferrer" target="_blank">https://github.com/ClangBuiltLinux/tc-build</a>>.<br>
<br>
> ./build-llvm.py --no-update --pgo --targets X86<br>
...<br>
[2240/2679] Building CXX object tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ASTReader.cpp.o<br>
FAILED: tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ASTReader.cpp.o<br>
/home/nathan/cbl/git/tc-build/build/llvm/stage1/bin/clang++ -DCLANG_VENDOR="\"ClangBuiltLinux \"" -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/lib/Serialization -I/home/nathan/cbl/git/tc-build/llvm-project/clang/lib/Serialization -I/home/nathan/cbl/git/tc-build/llvm-project/clang/include -Itools/clang/include -I/usr/include/libxml2 -Iinclude -I/home/nathan/cbl/git/tc-build/llvm-project/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++14 -w -fdiagnostics-color -ffunction-sections -fdata-sections -fprofile-generate='/home/nathan/cbl/git/tc-build/build/llvm/stage2/profiles' -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -fno-exceptions -fno-rtti -MD -MT tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ASTReader.cpp.o -MF tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ASTReader.cpp.o.d -o tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ASTReader.cpp.o -c /home/nathan/cbl/git/tc-build/llvm-project/clang/lib/Serialization/ASTReader.cpp<br>
fatal error: error in backend: Cannot select: 0xfe3cc48: i64 = shl 0x117c5360, Constant:i64<32><br>
0x117c5360: i64,ch = load<(load 4 from %ir.255 + 12), zext from i32> 0x104ce840, 0x119702e0, undef:i64<br>
0x119702e0: i64 = add nuw 0x1196e8d8, Constant:i64<4><br>
0x1196e8d8: i64 = add 0x117ced30, Constant:i64<16><br>
0x117ced30: i64,ch = load<(dereferenceable load 8 from %ir.32, !tbaa !9)> 0x104ce840, FrameIndex:i64<2>, undef:i64<br>
0x119d4430: i64 = FrameIndex<2><br>
0x119d3a08: i64 = undef<br>
0x119d4228: i64 = Constant<16><br>
0x10385118: i64 = Constant<4><br>
0x119d3a08: i64 = undef<br>
0x11a762d0: i64 = Constant<32><br>
In function: _ZN5clang9ASTReader22ParseDiagnosticOptionsERKN4llvm11SmallVectorImLj64EEEbRNS_17ASTReaderListenerE<br>
clang-10: error: clang frontend command failed with exit code 70 (use -v to see invocation)<br>
ClangBuiltLinux clang version 10.0.0 (git://<a href="http://github.com/llvm/llvm-project" rel="noreferrer" target="_blank">github.com/llvm/llvm-project</a> b7075e40f3c2244073fed1bf64f922165987f68a) (based on LLVM 10.0.0svn)<br>
Target: x86_64-unknown-linux-gnu<br>
Thread model: posix<br>
InstalledDir: /home/nathan/cbl/git/tc-build/build/llvm/stage1/bin<br>
clang-10: note: diagnostic msg: PLEASE submit a bug report to <a href="https://bugs.llvm.org/" rel="noreferrer" target="_blank">https://bugs.llvm.org/</a> and include the crash backtrace, preprocessed source, and associated run script.<br>
clang-10: note: diagnostic msg:<br>
********************<br>
<br>
PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:<br>
Preprocessed source(s) and associated run script(s) are located at:<br>
clang-10: note: diagnostic msg: /tmp/ASTReader-e6c71c.cpp<br>
clang-10: note: diagnostic msg: /tmp/ASTReader-e6c71c.sh<br>
clang-10: note: diagnostic msg:<br>
<br>
********************<br>
...<br>
> git -C llvm-project bisect log<br>
# bad: [8679ef4e46a4d7b46a521a905d60357854117d43] [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation<br>
# good: [894b8d1d85a13fe106411c996e26e571c00dbb78] FileManager: Factor duplicated code in getBufferForFile, NFC<br>
git bisect start 'origin/master' '894b8d1d85a'<br>
# good: [f899bf135fc5b7bb030b90da686d9d89bb97d18f] Fix windows build after r369894<br>
git bisect good f899bf135fc5b7bb030b90da686d9d89bb97d18f<br>
# good: [442a5765ce0c1594874a44f7aa210dfd0e0c5c35] [PowerPC] add tests for fma with negated ops; NFC<br>
git bisect good 442a5765ce0c1594874a44f7aa210dfd0e0c5c35<br>
# bad: [7305397a142a60d104e02ef1046b4289f957da95] TestFunctionStarts.py: add synchronization<br>
git bisect bad 7305397a142a60d104e02ef1046b4289f957da95<br>
# good: [e30b71f9dc0fdf12c3ea2ce4541ca8ce4af2aa67] Fix -dA flag, it is not a preprocessor flag.<br>
git bisect good e30b71f9dc0fdf12c3ea2ce4541ca8ce4af2aa67<br>
# bad: [3ba0f3c9b7f1c0227ed7771168fa9362cfea213e] [NFC] Add comments to some bool arguments for better readability<br>
git bisect bad 3ba0f3c9b7f1c0227ed7771168fa9362cfea213e<br>
# bad: [b7075e40f3c2244073fed1bf64f922165987f68a] [DAGCombiner] Remove a bunch of redundant AddToWorklist calls.<br>
git bisect bad b7075e40f3c2244073fed1bf64f922165987f68a<br>
# first bad commit: [b7075e40f3c2244073fed1bf64f922165987f68a] [DAGCombiner] Remove a bunch of redundant AddToWorklist calls.<br>
<br>
F9862512: ASTReader-e6c71c.sh <<a href="https://reviews.llvm.org/F9862512" rel="noreferrer" target="_blank">https://reviews.llvm.org/F9862512</a>><br>
<br>
F9862507: ASTReader-e6c71c.cpp <<a href="https://reviews.llvm.org/F9862507" rel="noreferrer" target="_blank">https://reviews.llvm.org/F9862507</a>><br>
<br>
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D66537/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D66537/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D66537" rel="noreferrer" target="_blank">https://reviews.llvm.org/D66537</a><br>
<br>
<br>
<br>
</blockquote></div>