[PATCH] D64082: [MemFunctions] Add microbenchmarks for memory functions.

Clément Courbet via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 03:56:09 PDT 2019


Sorry about that, fixed in r369888.

On Sat, Aug 24, 2019 at 1:25 AM Chris Matthews <chris.matthews at apple.com>
wrote:

> This seems to have broken the test-suite for me on some older systems.
>
> MicroBenchmarks/MemFunctions/main.cpp:34:10: error: unknown type name
> 'constexpr'
>   static constexpr size_t kMaxBufSizeBytes = 4096;
>          ^
>
> Could your cmake maybe explicitly set the C++ version?
>
> > On Jul 2, 2019, at 8:53 AM, Clement Courbet via Phabricator via
> llvm-commits <llvm-commits at lists.llvm.org> wrote:
> >
> > courbet created this revision.
> > Herald added a subscriber: mgorny.
> > Herald added a project: LLVM.
> >
> > Memory functions (memcmp, memcpy, ...) are typically recognized by the
> > compiler and expanded to specific asm patterns when the size is known at
> > compile time.
> >
> > This will help catch any regressions in expansions.
> >
> > Right now we're only testing memcmp (see context in D60318 <
> https://reviews.llvm.org/D60318>).
> >
> >
> > Repository:
> >  rT test-suite
> >
> > https://reviews.llvm.org/D64082
> >
> > Files:
> >  MicroBenchmarks/CMakeLists.txt
> >  MicroBenchmarks/MemFunctions/CMakeLists.txt
> >  MicroBenchmarks/MemFunctions/main.cpp
> >
> > <D64082.207570.patch>_______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190826/a59f0729/attachment.html>


More information about the llvm-commits mailing list