<div dir="ltr">Sorry about that, fixed in r369888.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Aug 24, 2019 at 1:25 AM Chris Matthews <<a href="mailto:chris.matthews@apple.com">chris.matthews@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This seems to have broken the test-suite for me on some older systems.<br>
<br>
MicroBenchmarks/MemFunctions/main.cpp:34:10: error: unknown type name 'constexpr'<br>
  static constexpr size_t kMaxBufSizeBytes = 4096;<br>
         ^<br>
<br>
Could your cmake maybe explicitly set the C++ version?<br>
<br>
> On Jul 2, 2019, at 8:53 AM, Clement Courbet via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> <br>
> courbet created this revision.<br>
> Herald added a subscriber: mgorny.<br>
> Herald added a project: LLVM.<br>
> <br>
> Memory functions (memcmp, memcpy, ...) are typically recognized by the<br>
> compiler and expanded to specific asm patterns when the size is known at<br>
> compile time.<br>
> <br>
> This will help catch any regressions in expansions.<br>
> <br>
> Right now we're only testing memcmp (see context in D60318 <<a href="https://reviews.llvm.org/D60318" rel="noreferrer" target="_blank">https://reviews.llvm.org/D60318</a>>).<br>
> <br>
> <br>
> Repository:<br>
>  rT test-suite<br>
> <br>
> <a href="https://reviews.llvm.org/D64082" rel="noreferrer" target="_blank">https://reviews.llvm.org/D64082</a><br>
> <br>
> Files:<br>
>  MicroBenchmarks/CMakeLists.txt<br>
>  MicroBenchmarks/MemFunctions/CMakeLists.txt<br>
>  MicroBenchmarks/MemFunctions/main.cpp<br>
> <br>
> <D64082.207570.patch>_______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></div>