[PATCH] D66719: [ELF] Do not ICF two sections with different output sections when there is a linker script
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 26 02:04:05 PDT 2019
grimar added a comment.
> D66717 <https://reviews.llvm.org/D66717> should be better
I still need to look at D66717 <https://reviews.llvm.org/D66717> closer, but I agree, I think this one is not a right approach probably.
Making sections dead and folding them, but then ressurrecting and unfolding looks
tricky: I do not think we have any other place where we set Live bit to
a dead input section (though we can do it for output section in `adjustSectionsBeforeSorting`).
Doing this seems breaks this part of LLD design and my impression is that we should avoid doing it.
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66719/new/
https://reviews.llvm.org/D66719
More information about the llvm-commits
mailing list