[PATCH] D66574: [lit] Make internal diff work in pipelines

[Joel E. Denny via Phabricator via llvm-commits]

jdenny marked 2 inline comments as done.
jdenny added inline comments.


================
Comment at: llvm/utils/lit/lit/builtin_commands/diff.py:196
+    try:
+        opts, args = getopt.gnu_getopt(args, "wbur", ["strip-trailing-cr"])
+    except getopt.GetoptError as err:
----------------
jdenny wrote:
> probinson wrote:
> > I've also seen "a" and "U1" in my searches.
> > Does this correctly handle combined short options? e.g. "-aub" which I see used a fair amount.
> > I didn't notice `--strip-trailing-cr` anywhere but presumably the original author needed it, so probably should keep it.
> > I was going to say we don't need to bother with "r" but then I found a case that used it!
> > I've also seen "a" and "U1" in my searches.
> 
> Looks like those will be easy to implement.  `difflib` appears to provide functionality for the latter.  I'll work on them.
> 
> > Does this correctly handle combined short options? e.g. "-aub" which I see used a fair amount.
> 
> I believe so, but I'll add some tests to be sure.
> 
> Thanks for researching the current usage!
I'll address these in separate patches.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66574/new/

https://reviews.llvm.org/D66574