[PATCH] D66574: [lit] Make internal diff work in pipelines

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 23 16:05:51 PDT 2019


jdenny added a comment.

In D66574#1643790 <https://reviews.llvm.org/D66574#1643790>, @jdenny wrote:

> I made several changes:
>
> - Added missing `functools`




- ... import to `diff.py`.
- Extracted `-` implementation.  I'll put that in a separate patch to make it easier to review.
- Fixed some missing newlines in diagnostics (bugs I introduced when converting from exceptions).
- Cleaned up some tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66574/new/

https://reviews.llvm.org/D66574





More information about the llvm-commits mailing list