[PATCH] D66625: [X86] Print register names in .seh_* directives

[Reid Kleckner via Phabricator via llvm-commits]

rnk marked 2 inline comments as done.
rnk added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3764
+    }
+  } else {
+    // Otherwise, an integer number matching the encoding of the desired
----------------
pengfei wrote:
> I saw lots of mixed use of register name and integer number in test cases. I think it may confuse user. Shall we disable the integer number supporting, or give a warning?
I think we should continue to accept the numbers to be GNU as compatible. I think the `directive_seh.s` and `seh-directive-errors.s` tests are the only remaining tests that use the numbers now, and they only exist to ensure we do the right thing with them.


================
Comment at: llvm/test/MC/AsmParser/directive_seh.s:22
+# CHECK: .seh_savexmm %xmm8, 0
+    .seh_savexmm %xmm8, 0
+# CHECK: .seh_savexmm %xmm8, 0
----------------
pengfei wrote:
> Seems duplicated
Oops, this was supposed to use a the number, but my sed command turned it into a register.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66625/new/

https://reviews.llvm.org/D66625