[PATCH] D66625: [X86] Print register names in .seh_* directives

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3764
+    }
+  } else {
+    // Otherwise, an integer number matching the encoding of the desired
----------------
I saw lots of mixed use of register name and integer number in test cases. I think it may confuse user. Shall we disable the integer number supporting, or give a warning?


================
Comment at: llvm/test/MC/AsmParser/directive_seh.s:22
+# CHECK: .seh_savexmm %xmm8, 0
+    .seh_savexmm %xmm8, 0
+# CHECK: .seh_savexmm %xmm8, 0
----------------
Seems duplicated


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66625/new/

https://reviews.llvm.org/D66625