[PATCH] D66513: [SampleFDO] Add ExtBinary format to support extension of binary profile

[Wei Mi via llvm-commits]

On Thu, Aug 22, 2019 at 2:24 PM David Li via Phabricator <
reviews at reviews.llvm.org> wrote:

> davidxl added a comment.
>
> LLC miss info should be very sparse, so mixing it with LBR may not bring a
> lot of benefit.  Having mixure of different types of profile data can lead
> to combinatorial growth of the number of readers. As the number of profile
> types increases, it can cause the reader to be unmaintaintable.  That is
> why I suggest making it clean -- one type per section.
>

That makes sense.


>
> Regarding compact format. Does it mean when LLC misses are included, there
> is no way to use the compact representation?
>

If compact format is ported to inherit from ExtBinaryBase, it is easy to
add LLC misses section to it.


>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D66513/new/
>
> https://reviews.llvm.org/D66513
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190822/5cc3889a/attachment.html>