[PATCH] D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files

Xing Xue via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 12:31:08 PDT 2019


xingxue marked 7 inline comments as done.
xingxue added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1663
+  if (!GVKind.isCommon() && !GVKind.isBSS() && !GVKind.isData())
+    report_fatal_error("Unsupported global variable kind.");
 
----------------
hubert.reinterpretcast wrote:
> Suggestion: "Encountered a global variable kind that is not supported yet."
Good catch, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66154/new/

https://reviews.llvm.org/D66154





More information about the llvm-commits mailing list