[PATCH] D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files

[Xing Xue via Phabricator via llvm-commits]

xingxue updated this revision to Diff 216660.
xingxue added a comment.

Addressed comments:

- Rename function `useDotAlignForPowerOfTwoAlignment()` to `useDotAlignForAlignment()` and the associated variable from `UseDotAlignForPowerOfTwoAlignment` to `UseDotAlignForAlignment`.
- Define `AsmPrinter::getGVAlignmentLog2()` as a static member function.
- Change from calling `llvm_unreachable()` to `assert()` as suggested for unsupported storage-mapping class of the `data` section.
- Fix the condition of supported global variable kind.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66154/new/

https://reviews.llvm.org/D66154

Files:
  llvm/include/llvm/CodeGen/AsmPrinter.h
  llvm/include/llvm/MC/MCAsmInfo.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  llvm/lib/MC/MCAsmInfoXCOFF.cpp
  llvm/lib/MC/MCAsmStreamer.cpp
  llvm/lib/MC/MCObjectFileInfo.cpp
  llvm/lib/MC/MCSectionXCOFF.cpp
  llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
  llvm/test/CodeGen/PowerPC/aix-xcoff-data.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66154.216660.patch
Type: text/x-patch
Size: 9806 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190822/f4dcbf8a/attachment-0001.bin>