[PATCH] D65697: [lit] Fix internal env calling env

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 14:44:38 PDT 2019


jdenny added a comment.

In D65697#1640109 <https://reviews.llvm.org/D65697#1640109>, @rnk wrote:

> Most LLVM test suites are configured to use the internal shell on Windows. I think what's happening is that users happen to have an external copy of `diff` that gets called when it appears in a pipeline, or they are prefixed by `not`. The external `diff` is called, and things "work out" and we never noticed.


Are these patches going to break those tests on Windows?  We now see `diff` anywhere in a pipeline, and we reject its appearance in a pipeline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65697/new/

https://reviews.llvm.org/D65697





More information about the llvm-commits mailing list