[PATCH] D65697: [lit] Fix internal env calling env

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In D65697#1640071 <https://reviews.llvm.org/D65697#1640071>, @jdenny wrote:

> The tests using an external diff in a pipeline are necessarily within test suites that never use lit's internal diff because the test suites are configured not to use lit's internal shell, right?  (That is assuming buggy cases like `env` or `not` calling diff don't come into play.)


Most LLVM test suites are configured to use the internal shell on Windows. I think what's happening is that users happen to have an external copy of `diff` that gets called when it appears in a pipeline, or they are prefixed by `not`. The external `diff` is called, and things "work out" and we never noticed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65697/new/

https://reviews.llvm.org/D65697