[PATCH] D66517: [llvm-objdump] - Remove one overload of reportError.

[George Rimar via Phabricator via llvm-commits]

grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: tools/llvm-objdump/MachODump.cpp:2409
                          ObjOrErr.takeError())) {
-            reportError(std::move(E), Filename, StringRef(), ArchitectureName);
+            reportError(std::move(E), "", Filename, ArchitectureName);
             continue;
----------------
jhenderson wrote:
> Should this be:
> 
> `reportError(std::move(E), Filename, "", ArchitectureName);`
I am not familar with MachO, but I think - no. Seems MachOUniversalBinary can contain
multiple objects and also `Filename` is reported as archive name around this place.

Note that my change did not change the original logic, and also that this error is untested.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66517/new/

https://reviews.llvm.org/D66517