[PATCH] D66517: [llvm-objdump] - Remove one of the `reportError` functions.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 21 02:41:29 PDT 2019


jhenderson added inline comments.


================
Comment at: tools/llvm-objdump/MachODump.cpp:2409
                          ObjOrErr.takeError())) {
-            reportError(std::move(E), Filename, StringRef(), ArchitectureName);
+            reportError(std::move(E), "", Filename, ArchitectureName);
             continue;
----------------
Should this be:

`reportError(std::move(E), Filename, "", ArchitectureName);`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66517/new/

https://reviews.llvm.org/D66517





More information about the llvm-commits mailing list