[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

Tue Aug 20 13:37:16 PDT 2019

leonardchan added a comment.

In D44672#1637984 <https://reviews.llvm.org/D44672#1637984>, @vsk wrote:

> In D44672#1637891 <https://reviews.llvm.org/D44672#1637891>, @leonardchan wrote:
>
> > It seems that this test leads to an `UNREACHABLE` under the new pass manager (can check this by adding `-fexperimental-new-pass-manager` to the test. I think this is because the passes for lowering the `llvm.coro` intrinsics are not yet ported to the new PM. Would it be fine to add `-fno-experimental-new-pass-manager` to the test to indicate it should be run under the legacy PM only? Thanks.
>
>
> Sounds reasonable to me. It would be great to include a link to some master PR for the new PM porting effort with the test change.

Thanks. I added you as a reviewer to D66493 <https://reviews.llvm.org/D66493> and linked in https://bugs.llvm.org/show_bug.cgi?id=42867 which I filed a while back and has the same root problem.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D44672/new/

https://reviews.llvm.org/D44672