[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 12:36:41 PDT 2019


vsk added a comment.

In D44672#1637891 <https://reviews.llvm.org/D44672#1637891>, @leonardchan wrote:

> It seems that this test leads to an `UNREACHABLE` under the new pass manager (can check this by adding `-fexperimental-new-pass-manager` to the test. I think this is because the passes for lowering the `llvm.coro` intrinsics are not yet ported to the new PM. Would it be fine to add `-fno-experimental-new-pass-manager` to the test to indicate it should be run under the legacy PM only? Thanks.


Sounds reasonable to me. It would be great to include a link to some master PR for the new PM porting effort with the test change.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D44672/new/

https://reviews.llvm.org/D44672





More information about the llvm-commits mailing list