[PATCH] D66401: [TargetMachine] Don't try to create COFFSTUB references on windows on non-COFF

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

This change should hopefully fix the errors in that log:

  diff --git a/test/CodeGen/AMDGPU/propagate-attributes-bitcast-function.ll b/test/CodeGen/AMDGPU/propagate-attributes-bitcast-function.ll
  index c1d8009d08b..173bc72db85 100644
  --- a/test/CodeGen/AMDGPU/propagate-attributes-bitcast-function.ll
  +++ b/test/CodeGen/AMDGPU/propagate-attributes-bitcast-function.ll
  @@ -1,4 +1,4 @@
  -; RUN: llc -march=amdgcn -mcpu=gfx1010 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
  +; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1010 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
   
   ; GCN: foo1:
   ; v_cndmask_b32_e64 v0, 0, 1, vcc_lo{{$}}
  diff --git a/test/CodeGen/AMDGPU/propagate-attributes-clone.ll b/test/CodeGen/AMDGPU/propagate-attributes-clone.ll
  index b9c36217aaa..cb0406c5b1f 100644
  --- a/test/CodeGen/AMDGPU/propagate-attributes-clone.ll
  +++ b/test/CodeGen/AMDGPU/propagate-attributes-clone.ll
  @@ -1,5 +1,5 @@
   ; RUN: opt -S -mtriple=amdgcn-amd-amdhsa -O1 < %s | FileCheck -check-prefix=OPT %s
  -; RUN: llc -march=amdgcn -mcpu=gfx1010 -verify-machineinstrs < %s | FileCheck -check-prefix=LLC %s
  +; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1010 -verify-machineinstrs < %s | FileCheck -check-prefix=LLC %s
   
   ; OPT: declare void @foo4() local_unnamed_addr #0
   ; OPT: define internal fastcc void @foo3.2() unnamed_addr #1
  diff --git a/test/CodeGen/AMDGPU/propagate-attributes-single-set.ll b/test/CodeGen/AMDGPU/propagate-attributes-single-set.ll
  index 34882586533..cb4283c8c67 100644
  --- a/test/CodeGen/AMDGPU/propagate-attributes-single-set.ll
  +++ b/test/CodeGen/AMDGPU/propagate-attributes-single-set.ll
  @@ -1,5 +1,5 @@
   ; RUN: opt -S -mtriple=amdgcn-amd-amdhsa -O1 < %s | FileCheck -check-prefix=OPT %s
  -; RUN: llc -march=amdgcn -mcpu=gfx1010 -verify-machineinstrs < %s | FileCheck -check-prefix=LLC %s
  +; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1010 -verify-machineinstrs < %s | FileCheck -check-prefix=LLC %s
   
   ; OPT: declare void @foo4() local_unnamed_addr #0
   ; OPT: define void @foo3() local_unnamed_addr #1
  diff --git a/test/CodeGen/Hexagon/pic-jt-big.ll b/test/CodeGen/Hexagon/pic-jt-big.ll
  index f5b4c2df52c..25ee04521b6 100644
  --- a/test/CodeGen/Hexagon/pic-jt-big.ll
  +++ b/test/CodeGen/Hexagon/pic-jt-big.ll
  @@ -1,4 +1,4 @@
  -; RUN: llc -march=hexagon -relocation-model=pic < %s | FileCheck %s
  +; RUN: llc -mtriple=hexagon-unknown-elf -relocation-model=pic < %s | FileCheck %s
   
   ; CHECK: r{{[0-9]+}} = add({{pc|PC}},##.LJTI{{[0-9_]+}}@PCREL)
   ; CHECK: r{{[0-9]+}} = memw(r{{[0-9]}}+##g0 at GOT
  diff --git a/test/CodeGen/Hexagon/pic-sdata.ll b/test/CodeGen/Hexagon/pic-sdata.ll
  index 3e4dc2dc93e..446734b9ca0 100644
  --- a/test/CodeGen/Hexagon/pic-sdata.ll
  +++ b/test/CodeGen/Hexagon/pic-sdata.ll
  @@ -1,5 +1,5 @@
  -; RUN: llc -march=hexagon -hexagon-small-data-threshold=8 -relocation-model=static < %s | FileCheck --check-prefixes=CHECK,STATIC %s
  -; RUN: llc -march=hexagon -hexagon-small-data-threshold=8 -relocation-model=pic < %s | FileCheck --check-prefixes=CHECK,PIC %s
  +; RUN: llc -mtriple=hexagon-unknown-elf -hexagon-small-data-threshold=8 -relocation-model=static < %s | FileCheck --check-prefixes=CHECK,STATIC %s
  +; RUN: llc -mtriple=hexagon-unknown-elf -hexagon-small-data-threshold=8 -relocation-model=pic < %s | FileCheck --check-prefixes=CHECK,PIC %s
   
   ; If a global has a specified section, it should probably be placed in that
   ; section, but with PIC any accesses to globals in small data should still
  diff --git a/test/CodeGen/SPARC/tls.ll b/test/CodeGen/SPARC/tls.ll
  index 1b1af2e99c3..843769df8d9 100644
  --- a/test/CodeGen/SPARC/tls.ll
  +++ b/test/CodeGen/SPARC/tls.ll
  @@ -1,12 +1,12 @@
  -; RUN: llc <%s -march=sparc   -relocation-model=static | FileCheck %s --check-prefix=v8abs
  -; RUN: llc <%s -march=sparcv9 -relocation-model=static | FileCheck %s --check-prefix=v9abs
  -; RUN: llc <%s -march=sparc   -relocation-model=pic    | FileCheck %s --check-prefix=pic
  -; RUN: llc <%s -march=sparcv9 -relocation-model=pic    | FileCheck %s --check-prefix=pic
  -
  -; RUN: llc <%s -march=sparc   -relocation-model=static -filetype=obj | llvm-readobj -r --symbols | FileCheck %s --check-prefix=v8abs-obj
  -; RUN: llc <%s -march=sparcv9 -relocation-model=static -filetype=obj | llvm-readobj -r --symbols | FileCheck %s --check-prefix=v9abs-obj
  -; RUN: llc <%s -march=sparc   -relocation-model=pic    -filetype=obj | llvm-readobj -r --symbols | FileCheck %s --check-prefix=pic-obj
  -; RUN: llc <%s -march=sparcv9 -relocation-model=pic    -filetype=obj | llvm-readobj -r --symbols | FileCheck %s --check-prefix=pic-obj
  +; RUN: llc <%s -mtriple=sparc-unknown-linux   -relocation-model=static | FileCheck %s --check-prefix=v8abs
  +; RUN: llc <%s -mtriple=sparcv9-unknown-linux -relocation-model=static | FileCheck %s --check-prefix=v9abs
  +; RUN: llc <%s -mtriple=sparc-unknown-linux   -relocation-model=pic    | FileCheck %s --check-prefix=pic
  +; RUN: llc <%s -mtriple=sparcv9-unknown-linux -relocation-model=pic    | FileCheck %s --check-prefix=pic
  +
  +; RUN: llc <%s -mtriple=sparc-unknown-linux   -relocation-model=static -filetype=obj | llvm-readobj -r --symbols | FileCheck %s --check-prefix=v8abs-obj
  +; RUN: llc <%s -mtriple=sparcv9-unknown-linux -relocation-model=static -filetype=obj | llvm-readobj -r --symbols | FileCheck %s --check-prefix=v9abs-obj
  +; RUN: llc <%s -mtriple=sparc-unknown-linux   -relocation-model=pic    -filetype=obj | llvm-readobj -r --symbols | FileCheck %s --check-prefix=pic-obj
  +; RUN: llc <%s -mtriple=sparcv9-unknown-linux -relocation-model=pic    -filetype=obj | llvm-readobj -r --symbols | FileCheck %s --check-prefix=pic-obj
   
   @local_symbol = internal thread_local global i32 0
   @extern_symbol = external thread_local global i32

Does that sound sensible? I tried to pick triple values matching what's used elsewhere in similar tests.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66401/new/

https://reviews.llvm.org/D66401