[PATCH] D66401: [TargetMachine] Don't try to create COFFSTUB references on windows on non-COFF

Tue Aug 20 13:10:00 PDT 2019

mstorsjo added a comment.

This apparently broke tests for a few other architectures, when the testsuite is run on windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/9816/steps/stage%201%20check/logs/stdio

These tests use plain e.g. `llc -march=amdgcn`. When run on windows, that ends up implicitly using a triple with a windows os, even though the tests probably didn't ever intend that.

I guess it should be ok to just amend those tests and change `-march` into `-mtriple` with a suitable non-windows os?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66401/new/

https://reviews.llvm.org/D66401