[PATCH] D66396: [TableGen] Correct comments for end of namespace. NFC

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 12:18:27 PDT 2019


bjope added a subscriber: stoklund.
bjope added a comment.

Basically I assume that nobody really cares about formatting and comments in generated code (so in one sense this is stupd, and in another sense it won't hurt much either).

The benefit is that if I run clang-tidy on the llvm/lib/Target code like this

  ../clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -clang-tidy-binary build/bin/clang-tidy -p build -header-filter=.* lib/Target/

then I will get less complaints related to the tablegen-generated code.

Haven't added any reviewers (and I don't really know who would be appropriate, @stoklund  is "code owner" for tablegen but haven't been active for over two years afaict).
Maybe this is something that even can be pushed without review? Or could some people be afraid of "unneccessary" diffs introduced by this patch, so I need to gather more opinions/feedback about this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66396/new/

https://reviews.llvm.org/D66396





More information about the llvm-commits mailing list