[PATCH] D65026: [Bugpoint redesign] Added pass to reduce Metadata

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

>From the discussion on https://reviews.llvm.org/D66110 - would it be possible/good to rewrite the "correctness" script to be a one-size-fits-all - diffing against a golden file of expected output (& maybe somehow deriving the golden file name from the original file name - which might be best achieved by copying both files to a temp directory)?

Like I said on that other review, I'm understanding of hesitance around golden files - and in this case it means another file to do IR upgrades on when LLVM textual IR changes (but most of those are done en-mass, so I don't think having twice the number of files for these tests is particularly problematic - there are already lots of other .ll files in Inputs directories around LLVM's tests, so anyone doing mass migration would already be scanning/patching them).

By doing it this way, it'll be easier to read in some ways - comparing one IR file to another (diffing, for instance). No need to complicate the interestingness test with novel ways to preserve features that aren't under test but are needed for the test (like preserving certain functions when you're trying to test that the metadata is removed from within the function).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65026/new/

https://reviews.llvm.org/D65026