[PATCH] D66464: Regex: +regex string lifetime comment

Jan Kratochvil via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 06:24:12 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL369383: Regex: +regex string lifetime comment (authored by jankratochvil, committed by ).
Herald added a subscriber: kristina.

Changed prior to commit:
  https://reviews.llvm.org/D66464?vs=216088&id=216128#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66464/new/

https://reviews.llvm.org/D66464

Files:
  llvm/trunk/include/llvm/Support/Regex.h


Index: llvm/trunk/include/llvm/Support/Regex.h
===================================================================
--- llvm/trunk/include/llvm/Support/Regex.h
+++ llvm/trunk/include/llvm/Support/Regex.h
@@ -44,6 +44,9 @@
 
     Regex();
     /// Compiles the given regular expression \p Regex.
+    ///
+    /// \param Regex - referenced string is no longer needed after this
+    /// constructor does finish.  Only its compiled form is kept stored.
     Regex(StringRef Regex, unsigned Flags = NoFlags);
     Regex(const Regex &) = delete;
     Regex &operator=(Regex regex) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66464.216128.patch
Type: text/x-patch
Size: 578 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190820/d7aeb342/attachment.bin>


More information about the llvm-commits mailing list