[PATCH] D66464: Regex: +regex string lifetime comment
Pavel Labath via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 20 04:27:11 PDT 2019
labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/include/llvm/Support/Regex.h:48
+ ///
+ /// \param Regex - referenced string lifetime is no longer needed after this
+ /// constructor does finish. Only its compiled form is kept stored.
----------------
I don't think you need the *lifetime* of that string -- you need the string itself. :) Just drop that word, and this will be fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66464/new/
https://reviews.llvm.org/D66464
More information about the llvm-commits
mailing list