[PATCH] D66468: [llvm-objdump] - Remove one of `report_error` functions and improve the error reporting.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 20 05:50:12 PDT 2019


grimar added inline comments.


================
Comment at: tools/llvm-objdump/MachODump.cpp:2486
           for (auto &C : A->children(Err)) {
             Expected<std::unique_ptr<Binary>> ChildOrErr = C.getAsBinary();
             if (!ChildOrErr) {
----------------
MaskRay wrote:
> Missing ++I ?
Yes :/ thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66468/new/

https://reviews.llvm.org/D66468





More information about the llvm-commits mailing list