[PATCH] D66468: [llvm-objdump] - Remove one of `report_error` functions and improve the error reporting.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 20 05:30:03 PDT 2019
jhenderson added inline comments.
================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:372
+ return NameOrErr.get();
+ // If we have a error getting the name then we print the index of which
+ // archive member this is. Since we already in a error state, we just
----------------
a error -> an error
print the index of which archive member this is -> print the index of the archive member
================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:373
+ // If we have a error getting the name then we print the index of which
+ // archive member this is. Since we already in a error state, we just
+ // ignore this error.
----------------
we already -> we are already
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66468/new/
https://reviews.llvm.org/D66468
More information about the llvm-commits
mailing list