[PATCH] D66432: [llvm-objcopy][NFC] Refactor symbol/section matching
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 20 02:24:16 PDT 2019
jhenderson added inline comments.
================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.h:101
+class MatcherSet {
+ std::vector<NameOrRegex> Matchers;
----------------
Maybe worth a comment?
Also `MatcherSet` probably is a bad name, since it's more a vector than a set...
How about `NameMatcher`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66432/new/
https://reviews.llvm.org/D66432
More information about the llvm-commits
mailing list