[PATCH] D66432: [llvm-objcopy][NFC] Refactor symbol/section matching
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 19 21:19:39 PDT 2019
MaskRay added a comment.
Looks good. With a nit:
================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.h:108
+ }
+ bool Matches(StringRef S) const { return is_contained(Matchers, S); }
+ bool empty() const { return Matchers.empty(); }
----------------
`AddMatcher` and `Matches` should not be capitalized.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66432/new/
https://reviews.llvm.org/D66432
More information about the llvm-commits
mailing list