[PATCH] D66401: [TargetMachine] Don't try to create COFFSTUB references on windows on non-COFF
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 19 21:14:57 PDT 2019
mstorsjo marked an inline comment as done.
mstorsjo added inline comments.
================
Comment at: lib/Target/TargetMachine.cpp:148
+ if (TT.isOSBinFormatCOFF() ||
+ (TT.isOSWindows() && (TT.isOSBinFormatMachO() || TT.isOSBinFormatELF())))
return true;
----------------
rnk wrote:
> Maybe this should be relaxed to just `isCOFF || isWindows`, rather than enumerating other formats.
Yes, that's probably best.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66401/new/
https://reviews.llvm.org/D66401
More information about the llvm-commits
mailing list