[PATCH] D66401: [TargetMachine] Don't try to create COFFSTUB references on windows on non-COFF

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lib/Target/TargetMachine.cpp:148
+  if (TT.isOSBinFormatCOFF() ||
+      (TT.isOSWindows() && (TT.isOSBinFormatMachO() || TT.isOSBinFormatELF())))
     return true;
----------------
Maybe this should be relaxed to just `isCOFF || isWindows`, rather than enumerating other formats.


================
Comment at: lib/Target/X86/X86Subtarget.cpp:149
   }
+  if (isOSWindows())
+    return X86II::MO_NO_FLAG;
----------------
This seems like it's trivially dead (Windows must use COFF, right? Actually, no), so I think it's worth a comment.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66401/new/

https://reviews.llvm.org/D66401