[PATCH] D62875: [GWP-ASan] Add public-facing documentation [6].

[Mitch Phillips via Phabricator via llvm-commits]

hctim marked 4 inline comments as done.
hctim added inline comments.


================
Comment at: llvm/docs/GwpAsan.rst:135
+  cmake configure time (e.g. ``cmake ... -GWP_ASAN_DEFAULT_OPTIONS="..."``). If
+  you're building GWP-ASan outside of compiler-rt, consult the manual for your
+  paticular instance (or just ensure that you specify
----------------
morehouse wrote:
> What manual?
Was supposed to be the manual for the supporting allocator, but I've removed some words here to try and clarify.


================
Comment at: llvm/docs/GwpAsan.rst:138
+  ``-GWP_ASAN_DEFAULT_OPTIONS="..."`` when building
+  ``optional/options_parser.cpp``).
+
----------------
morehouse wrote:
> Do we expect/want-to-support building outside of compiler-rt?  If we encourage this, we may end up with many forks of GWP-ASan.
I think that supporting out-of-RT builds is necessary. We've got an Android repository slice up and going that will definitely be out-of-tree builds.

My goal is basically to have the core `**/*.h` and `**/*.cpp`. If you want to use GWP-ASan, simply pull in the slice of the repository and add it to your build.

Maybe I should copybara slice this out of CRT and keep a makefile-independent (read: only cpp and header files) version so that it can be mirrored everywhere... WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62875/new/

https://reviews.llvm.org/D62875