[PATCH] D62875: [GWP-ASan] Add public-facing documentation [6].

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added inline comments.


================
Comment at: llvm/docs/GwpAsan.rst:134
+  If you're building GWP-ASan as part of a compiler-rt/LLVM build, add it during
+  cmake configure time (e.g. ``cmake ... -GWP_ASAN_DEFAULT_OPTIONS="..."``). If
+  you're building GWP-ASan outside of compiler-rt, consult the manual for your
----------------
Shouldn't this be `-DGWP_ASAN_DEFAULT_OPTIONS`?


================
Comment at: llvm/docs/GwpAsan.rst:135
+  cmake configure time (e.g. ``cmake ... -GWP_ASAN_DEFAULT_OPTIONS="..."``). If
+  you're building GWP-ASan outside of compiler-rt, consult the manual for your
+  paticular instance (or just ensure that you specify
----------------
What manual?


================
Comment at: llvm/docs/GwpAsan.rst:138
+  ``-GWP_ASAN_DEFAULT_OPTIONS="..."`` when building
+  ``optional/options_parser.cpp``).
+
----------------
Do we expect/want-to-support building outside of compiler-rt?  If we encourage this, we may end up with many forks of GWP-ASan.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62875/new/

https://reviews.llvm.org/D62875