[PATCH] D66355: [COFF] Add libcall symbols to the link when LTO is being used.

Amy Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 19 15:05:16 PDT 2019


akhuang marked an inline comment as done.
akhuang added inline comments.


================
Comment at: lld/COFF/SymbolTable.cpp:594
+    MemoryBufferRef mb = l->getMemberBuffer();
+    if (identify_magic(mb.getBuffer()) == llvm::file_magic::bitcode)
+      addUndefined(sym->getName());
----------------
rnk wrote:
> I'd use `isa<BitcodeFile>(l->getFile())` instead, rather than checking for the magic bytes again.
It seems like `isa<BitcodeFile>(l->getFile())` is always false and the file is an ArchiveFile?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66355/new/

https://reviews.llvm.org/D66355





More information about the llvm-commits mailing list