[PATCH] D66355: [COFF] Add libcall symbols to the link when LTO is being used.

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm with one change



================
Comment at: lld/COFF/SymbolTable.cpp:594
+    MemoryBufferRef mb = l->getMemberBuffer();
+    if (identify_magic(mb.getBuffer()) == llvm::file_magic::bitcode)
+      addUndefined(sym->getName());
----------------
I'd use `isa<BitcodeFile>(l->getFile())` instead, rather than checking for the magic bytes again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66355/new/

https://reviews.llvm.org/D66355