[PATCH] D66339: [SVE] Fixed-length vector MVT ranges

David Greene via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 16 10:26:37 PDT 2019


greened added a comment.

In D66339#1632975 <https://reviews.llvm.org/D66339#1632975>, @sdesmalen wrote:

> I like your suggestion of using `concat_iterator(_range)`, but I think grouping all fixed-width types together is sufficient for now. If there is ever a good reason to iterate through `(all combined scalable and fixed-width fp vector types)`or `(all combined scalable and fixed-width integer vector types)`, we can always introduce the extra `concat_iterators` then.


I'm not sure what you're suggesting here.  Are you asking Graham to keep all the fixed-width types contiguous (i.e. int and fp)?  This patch does not do that.  I don't have a strong preference either way.  Given that the existing state is non-contiguous I see no compelling reason to change it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66339/new/

https://reviews.llvm.org/D66339





More information about the llvm-commits mailing list