[PATCH] D66339: [SVE] Fixed-length vector MVT ranges
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 16 05:59:17 PDT 2019
sdesmalen added a comment.
In D66339#1632857 <https://reviews.llvm.org/D66339#1632857>, @huntergr wrote:
> Split out from D53137 <https://reviews.llvm.org/D53137>.
Thanks!
> I added new range functions for fp and int fixedlen types, but not all fixedlen vector valuetypes; the fixedlen MVTs are not contiguous.
>
> If we want to provide that, I could reorder the MVT list to group all fixedlen types together (and the same for all scalable types), but we then lose direct lists of all fp/int types. The concat or filter iterators from STLExtras could be used to fix those if needed. Any preferences?
I like your suggestion of using `concat_iterator(_range)`, but I think grouping all fixed-width types together is sufficient for now. If there is ever a good reason to iterate through `(all combined scalable and fixed-width fp vector types)`or `(all combined scalable and fixed-width integer vector types)`, we can always introduce the extra `concat_iterators` then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66339/new/
https://reviews.llvm.org/D66339
More information about the llvm-commits
mailing list