[PATCH] D65542: [PeepholeOptimizer] Don't assume bitcast def always has input

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/bitcast-peephole.mir:2
+# RUN: llc -mtriple=powerpc64le-linux-gnu -run-pass=peephole-opt -verify-machineinstrs -o - %s | FileCheck %s
+# REQUIRES: asserts
+
----------------
qcolombet wrote:
> Instead of requiring assertion, I would just explicitly check that the number of operands is correct.
> You can use `update_mir_test_check.py` to generate the check lines for this.
Scratch my last comment on the number of operands!
Still would generating the CHECK lines with the update script would have caught the bug without having to rely on asserts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65542/new/

https://reviews.llvm.org/D65542