[PATCH] D65542: [PeepholeOptimizer] Don't assume bitcast def always has input

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 16 10:49:35 PDT 2019


qcolombet added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/bitcast-peephole.mir:2
+# RUN: llc -mtriple=powerpc64le-linux-gnu -run-pass=peephole-opt -verify-machineinstrs -o - %s | FileCheck %s
+# REQUIRES: asserts
+
----------------
Instead of requiring assertion, I would just explicitly check that the number of operands is correct.
You can use `update_mir_test_check.py` to generate the check lines for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65542/new/

https://reviews.llvm.org/D65542





More information about the llvm-commits mailing list