[PATCH] D66346: [LLD][ELF][ARM] Add a test that maxes out the thunk convergence limit
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 16 09:11:45 PDT 2019
MaskRay added inline comments.
================
Comment at: lld/test/ELF/arm-thunk-many-passes.s:62
+ .section .text.01, "ax", %progbits
+ .space 14 * 1024 * 1024
+ .section .text.02, "ax", %progbits
----------------
Probably add a comment saying that thunks are placed before .text.02. In each iteration a new thunk is created for one f* function but the 4 bytes it adds also makes the next function out of reach from the b.w instruction.
================
Comment at: lld/test/ELF/arm-thunk-many-passes.s:63
+ .space 14 * 1024 * 1024
+ .section .text.02, "ax", %progbits
+ .space 1024 * 1024
----------------
It seems the two .text.02 can be merged
```
.section .text.02, "ax", %progbits
.space 2 * 1024 * 1024 - 68
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66346/new/
https://reviews.llvm.org/D66346
More information about the llvm-commits
mailing list