[PATCH] D66346: [LLD][ELF][ARM] Add a test that maxes out the thunk convergence limit
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 16 06:44:47 PDT 2019
peter.smith created this revision.
peter.smith added reviewers: ruiu, MaskRay, grimar.
Herald added subscribers: kristof.beyls, arichardson, javed.absar, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
Add a test that takes the maximum amount of passes permitted to converge. This will make sure that any symbol defined in a linker script gets the correct value and that any other convergence limit involving symbol address doesn't restrict Thunk convergence.
Related to D66279 <https://reviews.llvm.org/D66279> which is looking at iterating until symbol addresses stabilize.
https://reviews.llvm.org/D66346
Files:
lld/test/ELF/arm-thunk-many-passes.s
Index: lld/test/ELF/arm-thunk-many-passes.s
===================================================================
--- /dev/null
+++ lld/test/ELF/arm-thunk-many-passes.s
@@ -0,0 +1,94 @@
+// REQUIRES: arm
+// RUN: llvm-mc -arm-add-build-attributes -filetype=obj -triple=armv7a-linux-gnueabihf %s -o %t
+// RUN: echo "SECTIONS { \
+// RUN: . = SIZEOF_HEADERS; \
+// RUN: .text 0x00011000 : { *(.text.*) } \
+// RUN: } \
+// RUN: sym = .;" > %t.script
+// RUN: ld.lld --script %t.script %t -o %t2
+// RUN: llvm-readobj --symbols %t2 | FileCheck --check-prefix CHECK-SYM %s
+// RUN: llvm-objdump --no-show-raw-insn --start-address=0x11000 --stop-address=0x1103c -d %t2 | FileCheck %s
+
+// A worst case case of thunk generation that takes 9 passes to converge
+// one fewer than the limit of 10.
+// We check that the thunks have been generated and a symbol defined after
+// the thunks has the correct value.
+
+// CHECK-SYM: Name: sym
+// CHECK-SYM-NEXT: Value: 0x101104C
+
+// CHECK: 00011000 _start:
+// CHECK-NEXT: 11000: b.w #14680132 <__Thumbv7ABSLongThunk_f3>
+// CHECK-NEXT: 11004: b.w #14680128 <__Thumbv7ABSLongThunk_f3>
+// CHECK-NEXT: 11008: b.w #14680128 <__Thumbv7ABSLongThunk_f4>
+// CHECK-NEXT: 1100c: b.w #14680124 <__Thumbv7ABSLongThunk_f4>
+// CHECK-NEXT: 11010: b.w #14680124 <__Thumbv7ABSLongThunk_f5>
+// CHECK-NEXT: 11014: b.w #14680120 <__Thumbv7ABSLongThunk_f5>
+// CHECK-NEXT: 11018: b.w #14680120 <__Thumbv7ABSLongThunk_f6>
+// CHECK-NEXT: 1101c: b.w #14680116 <__Thumbv7ABSLongThunk_f6>
+// CHECK-NEXT: 11020: b.w #14680116 <__Thumbv7ABSLongThunk_f7>
+// CHECK-NEXT: 11024: b.w #14680112 <__Thumbv7ABSLongThunk_f7>
+// CHECK-NEXT: 11028: b.w #14680112 <__Thumbv7ABSLongThunk_f8>
+// CHECK-NEXT: 1102c: b.w #14680108 <__Thumbv7ABSLongThunk_f8>
+// CHECK-NEXT: 11030: b.w #14680108 <__Thumbv7ABSLongThunk_f9>
+// CHECK-NEXT: 11034: b.w #14680104 <__Thumbv7ABSLongThunk_f9>
+// CHECK-NEXT: 11038: b.w #14680104 <__Thumbv7ABSLongThunk_f10>
+
+
+ .thumb
+ .section .text.00, "ax", %progbits
+ .globl _start
+ .thumb_func
+_start: b.w f2
+ b.w f2
+ b.w f3
+ b.w f3
+ b.w f4
+ b.w f4
+ b.w f5
+ b.w f5
+ b.w f6
+ b.w f6
+ b.w f7
+ b.w f7
+ b.w f8
+ b.w f8
+ b.w f9
+ b.w f9
+ b.w f10
+ b.w f10
+
+ .section .text.01, "ax", %progbits
+ .space 14 * 1024 * 1024
+ .section .text.02, "ax", %progbits
+ .space 1024 * 1024
+ .section .text.02, "ax", %progbits
+ .space (1024 * 1024) - 68
+ .thumb_func
+f2: bx lr
+ nop
+ .thumb_func
+f3: bx lr
+ nop
+ .thumb_func
+f4: bx lr
+ nop
+ .thumb_func
+f5: bx lr
+ nop
+ .thumb_func
+f6: bx lr
+ nop
+ .thumb_func
+f7: bx lr
+ nop
+ .thumb_func
+f8: bx lr
+ nop
+ .thumb_func
+f9: bx lr
+ nop
+ .thumb_func
+f10: bx lr
+ nop
+ .thumb_func
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66346.215585.patch
Type: text/x-patch
Size: 3292 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190816/c91572c1/attachment.bin>
More information about the llvm-commits
mailing list