[PATCH] D65683: MVT: Add v3i16/v3f16 vectors
Mikael Holmén via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 16 00:38:20 PDT 2019
uabelho added inline comments.
================
Comment at: utils/TableGen/IntrinsicEmitter.cpp:224
+ IIT_VEC_ELEMENT = 42,
+ IIT_V48 = 43
};
----------------
arsenm wrote:
> craig.topper wrote:
> > Is this needed for this patch or a future patch that adds an intrinsic?
> I hit this I think due to a bug in updating the ValueTypes.td enum values and can probably be dropped. The only intrinsics that would use this use a mangled parameter
But if it's kept (which it is in r369038) it needs to be added to the enum in Function.cpp too according to a comment above:
// NOTE: This must be kept in synch with the copy in lib/IR/Function.cpp!
Right now the two enums are not in sync.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65683/new/
https://reviews.llvm.org/D65683
More information about the llvm-commits
mailing list