[PATCH] D37215: [ValueTracking] improve reverse assumption inference

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 12 13:04:08 PDT 2019


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

In D37215#1624744 <https://reviews.llvm.org/D37215#1624744>, @lebedev.ri wrote:

> I suspect that if this is rewritten with `MustBeExecutedContextExplorer`, @jdoerfert would review.


That depends on the use case. I think we should use the explorer either way but initially in "block-only" mode, which is what is happening here.
One can then decide if more elaborate modes make sense.

For now, I'd be fine with not using the explorer to not block this. In fact, this looks good to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D37215/new/

https://reviews.llvm.org/D37215





More information about the llvm-commits mailing list