[PATCH] D66246: [AMDGPU] Do not assume a default GCN target

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: lib/Basic/Targets/AMDGPU.cpp:188-189
       break;
     case GK_NONE:
-      return false;
+      break;
     default:
----------------
arsenm wrote:
> I think this needs to distinguish no specified target from an invalid cpu name
It does. clang then exits with "error: unknown target CPU":


```
clang -cc1 -triple amdgcn-amd-amdhsa -target-cpu invalid gas.cl
error: unknown target CPU 'invalid'
note: valid target CPU values are: gfx600, tahiti, gfx601, hainan, oland, pitcairn, verde, gfx700, kaveri, gfx701, hawaii, gfx702, gfx703, kabini, mullins, gfx704, bonaire, gfx801, carrizo, gfx802, iceland, tonga, gfx803, fiji, polaris10, polaris11, gfx810, stoney, gfx900, gfx902, gfx904, gfx906, gfx908, gfx909, gfx1010, gfx1011, gfx1012
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66246/new/

https://reviews.llvm.org/D66246